Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): unregister tables from hummock manager during recovery #15355

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Feb 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR fixes GlobalBarrierManager::pre_apply_drop_cancel. It didn't unregister tables from HummockManager, which might cause #15144.
This PR also replace invocation of HummockManager::unregister_table_ids_fail_fast with LocalNotification::UnregisterTablesFromHummock. Because HummockManager may not always be accessible.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28
Copy link
Contributor Author

zwang28 commented Feb 29, 2024

Blocked by #15357

@zwang28 zwang28 enabled auto-merge March 7, 2024 03:02
@zwang28 zwang28 added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 49c2070 Mar 7, 2024
26 of 27 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_unregister branch March 7, 2024 04:01
zwang28 added a commit that referenced this pull request Mar 7, 2024
…5355)

# Conflicts:
#	src/meta/src/barrier/recovery.rs
#	src/meta/src/manager/metadata.rs
#	src/meta/src/stream/stream_manager.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants