Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panics in find_columns_by_ids #15338

Merged
merged 3 commits into from
Feb 29, 2024
Merged

fix: panics in find_columns_by_ids #15338

merged 3 commits into from
Feb 29, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #15074 for background. The bugfix is simply changing remove() to get().

close #15074
close #15075

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Feb 28, 2024
@fuyufjh fuyufjh requested a review from st1page February 28, 2024 08:56
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuyufjh fuyufjh enabled auto-merge February 28, 2024 09:14
@fuyufjh fuyufjh added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@st1page st1page added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@fuyufjh fuyufjh enabled auto-merge February 29, 2024 03:35
@fuyufjh fuyufjh added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit d3a3363 Feb 29, 2024
26 of 27 checks passed
@fuyufjh fuyufjh deleted the eric/fix_15074 branch February 29, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
2 participants