refactor: do not output suppressed count when it's zero #15333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
fuyufjh
approved these changes
Feb 28, 2024
fuyufjh
reviewed
Feb 28, 2024
src/common/src/log.rs
Outdated
| @@ -86,7 +89,7 @@ mod tests { | |||
| }); | |||
|
|
|||
| if let Ok(suppressed_count) = RATE_LIMITER.check() { | |||
| println!("failed to foo bar. suppressed_count = {}", suppressed_count); | |||
| println!("failed to foo bar. suppressed_count = {:?}", suppressed_count); | |||
There was a problem hiding this comment.
It does not look good. 😄 We usually record it as a tracing field in production code. Updated the test code accordingly and it now looks like this:
Signed-off-by: Bugen Zhao <[email protected]>
StrikeW
approved these changes
Feb 29, 2024
tabVersion
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Make
LogSuppressor::checkreturnsOption<NonZeroUsize>and record the option value in tracing events. When the suppressed count is zero, the field will be omitted in the event.Also fixed direct error formatting in
mysqlandpostgresparser. These are corner cases that are not covered by the lints. Tracked in #15330.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.