Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support decimal type for iceberg type #15298

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • related issue: Feat: Batch ingest iceberg/file source #14742
  • Support decimal type for iceberg source. We have used arrow-risingwave datatype conversion before, but since this conversion was designed for UDF originally it lacks some conversion between iceberg/arrow decimal and risingwave decimal, so we added the decimal support in this PR.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested review from ZENOTME, wangrunji0408 and liurenjie1024 and removed request for ZENOTME February 27, 2024 10:09
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, left some comments.

src/frontend/src/handler/create_source.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/create_source.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/create_source.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/create_source.rs Outdated Show resolved Hide resolved
src/common/src/array/arrow/arrow_impl.rs Outdated Show resolved Hide resolved
src/common/src/array/arrow/arrow_impl.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chenzl25 chenzl25 added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit c2734d0 Feb 28, 2024
33 of 34 checks passed
@chenzl25 chenzl25 deleted the dylan/support_decimal_for_iceberg_source branch February 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants