Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dashboard): refactor back pressure api path name #15277

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

yufansong
Copy link
Member

@yufansong yufansong commented Feb 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As suggest in #14863 comments, do some refactor to seperate the embeded back pressure and prometheus back pressure.
Change /metrics/actor/back_pressures to /metrics/fragment/prometheus_back_pressures
Change /metrics/back_pressures to /metrics/fragment/embedded_back_pressures

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yufansong yufansong added this pull request to the merge queue Feb 27, 2024
@fuyufjh
Copy link
Member

fuyufjh commented Feb 27, 2024

This will actually break the old-version RW, but it's acceptable to me.

This is because RisingWave's Web resources are served from GitHub repo dashboard-artifact branch, and it's not versioned, i.e. only the latest main build will be kept.

RUN curl -LO https://github.com/risingwavelabs/risingwave/archive/refs/heads/dashboard-artifact.zip
RUN unzip dashboard-artifact.zip && mv risingwave-dashboard-artifact /risingwave/ui && rm dashboard-artifact.zip

Hope someday we can ship the frontend resource into / along with the binary.

Merged via the queue into main with commit 775de18 Feb 27, 2024
29 of 30 checks passed
@yufansong yufansong deleted the yufan/bp_rename branch February 27, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants