-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow retention_seconds on append only table and its downstream index #15268
feat: allow retention_seconds on append only table and its downstream index #15268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4825 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2093 | 1 | 2731 | 0 |
Click to see the invalid file list
- src/frontend/src/optimizer/mod.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…thub.com:risingwavelabs/risingwave into sts/allow_retention_seconds_on_append_only_table
…thub.com:risingwavelabs/risingwave into sts/allow_retention_seconds_on_append_only_table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e2e_test/ddl/table/table.slt.part
Outdated
1 | ||
|
||
statement ok | ||
select pg_sleep(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ. Once a row has expired, but hasn't been removed by compactor yet, will the scan iterator "hides" it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember there is some code in state store implementation to "hide" it. need to check @Li0k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely hide it, by filtering it in the min_epoch
of the iterator on the read path.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #14791
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Users can set TTL(time to live) on the append-only table with the
retention_seconds
option and the record will be removed from the table after the retention seconds passed.The same retention seconds will be applied to the table's downstream index automatically.