Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add name column back in pg_user for backward compatibility #15266

Merged
merged 1 commit into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e_test/batch/catalog/pg_user.slt.part
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
query ITTT
SELECT * FROM pg_catalog.pg_user order by usesysid;
SELECT usesysid, usename, usecreatedb, usesuper, passwd FROM pg_catalog.pg_user order by usesysid;
----
1 root t t ********
2 postgres t t ********
2 changes: 2 additions & 0 deletions src/frontend/src/catalog/system_catalog/pg_catalog/pg_user.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use risingwave_frontend_macro::system_catalog;
"pg_catalog.pg_user",
"SELECT id AS usesysid,
name,
name AS usename,
create_db AS usecreatedb,
is_super AS usesuper,
'********' AS passwd
Expand All @@ -30,6 +31,7 @@ use risingwave_frontend_macro::system_catalog;
#[derive(Fields)]
struct PgUser {
usesysid: i32,
name: String, // FIXME: For backward compatibility, remove it when the cloud update it.
usename: String,
usecreatedb: bool,
usesuper: bool,
Expand Down
Loading