fix: pass correct object store config to monitored object store for all backends #15260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of topic, do we still need await tree for opendal object store? #15259 |
I think it depends on the complexity. If it is easy to integrate opendal await tree with our await tree, it is a good-to-have. |
added in #15259, I think it's easy, and the result will added after risingwave’s original await tree |
zwang28
pushed a commit
that referenced
this pull request
Feb 26, 2024
zwang28
pushed a commit
that referenced
this pull request
Feb 26, 2024
hzxa21
added a commit
that referenced
this pull request
Feb 26, 2024
lmatz
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously, we only pass object store config to S3 object store only. This makes the timeout config to be None for all other object stores including all object store backends implemented via OpenDAL.
This should be the cause for #15209 and #15239.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.