fix(storage): fix leaving put key after delete keys are dropped cause inconsistent #15232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #15057 (comment)
When we put some keys and then delete them in one epoch, if hummock enable "spill memtable", and then compact them in the last level of LSM tree, compactor may lost DELETE keys when and only when the safe watermark keeps same with just flushed epoch. We used to assume that the epoch of current keys must be larger than the follower keys, but it is wrong since we start using pure epoch to decide whether it shall be dropped.
So compactor drops the delete keys and left the put key because they share the same
pure_epoch
and it exactly equalstask_config.watermark
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.