Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle upsert json in prev versions #15226

Merged
merged 12 commits into from
Feb 26, 2024
Merged

fix: handle upsert json in prev versions #15226

merged 12 commits into from
Feb 26, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

rewrite the catalog in compute node to match the include key as pattern, which is required in parser now.

rewrite condition:

  • format upsert
  • encode protobuf / encode avro / encode json
  • column type bytea
  • column name _rw_key

what to do

  • edit the column's additional_column to AdditionalColumnType::Key

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Feb 23, 2024
@tabVersion tabVersion added the ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. label Feb 23, 2024
@tabVersion tabVersion requested a review from kwannoel February 23, 2024 09:18
@tabVersion
Copy link
Contributor Author

incompatibility found:

@tabVersion tabVersion enabled auto-merge February 26, 2024 04:02
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tabVersion tabVersion added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit fcdeb3f Feb 26, 2024
32 of 34 checks passed
@tabVersion tabVersion deleted the tab/fix-upsert branch February 26, 2024 04:38
tabVersion added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants