-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): allow minio to use aws sdk or opendal #15208
Merged
+70
−5
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a379cdb
save work
wcy-fdu 4e52419
implement new s3 via OpenDAL
wcy-fdu 95ae846
update Copyright
wcy-fdu c2d8280
typo
wcy-fdu c898678
add region
wcy-fdu b1a9adf
switch minio to new s3
wcy-fdu 6c85ce0
swithch minio to opendal s3, default unable
wcy-fdu f02a8b2
clean risedev.yml
wcy-fdu 87699c4
minor
wcy-fdu b5e6942
minor
wcy-fdu 1799cde
add config for minio
wcy-fdu 6dd6784
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
wcy-fdu b90d2ad
rebase main
wcy-fdu 5c222f1
update backon
wcy-fdu c0970e0
rebase main
wcy-fdu 5f272c9
resolve comment
wcy-fdu fa1c7dc
rollback
wcy-fdu a765473
do not change cargo.lock
wcy-fdu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it can be better to use the
url
crate to parse the URL here instead of doing it manually. Less code and less possibility of security problems.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm just tried, but the here it's not a normal url(
127.0.0.1:9301/hummock001
, instead ofhttp://127.0.0.1:9301/hummock001
), so just keep it the same as before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"minio://" is part of the URL, which will result in
parsed_url.scheme() == "minio"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the use of all state store urls in later PR.