Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): visit ternary ops when offset is specified for tumble #15199

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Feb 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #15198.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

xzhseh commented Feb 22, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@xzhseh xzhseh changed the title use tenary when offset is specified fix( Feb 22, 2024
@xzhseh xzhseh changed the title fix( fix(optimizer): visit ternary when offset is specified for tumble Feb 22, 2024
@xzhseh xzhseh changed the title fix(optimizer): visit ternary when offset is specified for tumble fix(optimizer): visit ternary ops when offset is specified for tumble Feb 22, 2024
@xzhseh xzhseh marked this pull request as ready for review February 22, 2024 17:00
@xzhseh
Copy link
Contributor Author

xzhseh commented Feb 22, 2024

Note that in most cases (e.g., with actual table involved), this path will not be executed, the essential problem is likely arose from the combination use of creating a temporary table & specifying an offset when using tumble. I haven't fully verified if this is the root cause, just a guess.

@xzhseh xzhseh self-assigned this Feb 22, 2024
@TennyZhuang TennyZhuang requested a review from chenzl25 February 22, 2024 17:27
@TennyZhuang TennyZhuang added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 62d897c Feb 23, 2024
31 of 32 checks passed
@TennyZhuang TennyZhuang deleted the xzhseh/fix-tumble-offset branch February 23, 2024 06:56
TennyZhuang pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when creating a materialized view with TUMBLE and offset
3 participants