Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try to reduce memory usage in scaling #15193

Merged
merged 6 commits into from
Feb 23, 2024
Merged

feat: try to reduce memory usage in scaling #15193

merged 6 commits into from
Feb 23, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Feb 22, 2024 •
edited
Loading

Signed-off-by: Shanicky Chen [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR attempts to reduce meta memory usage during the scaling process by substituting the original PbStreamActor and PbFragment with custom-designed CustomActorInfo and CustomFragmentInfo, thereby reducing memory usage by minimizing the memory replication of nodes.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@shanicky shanicky changed the title feat: try reduce memory usage in scaling feat: try to reduce memory usage in scaling Feb 22, 2024
yezizp2012
yezizp2012 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for the job.

@yezizp2012 yezizp2012 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit c6ed6d1 Feb 23, 2024
27 checks passed
@yezizp2012 yezizp2012 deleted the peng/try-reduce-scale-memory branch February 23, 2024 05:30
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
@shanicky
feat: try to reduce memory usage in scaling (#15193)
b01be47 
Signed-off-by: Shanicky Chen <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
Merged
shanicky added a commit that referenced this pull request Feb 23, 2024
@github-actions @shanicky
feat: try to reduce memory usage in scaling (#15193) (#15207)
6a84330 
Signed-off-by: Shanicky Chen <[email protected]>
Co-authored-by: Shanicky Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanicky @yezizp2012