Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): allow explicit cast serial to bigint #15184

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

TennyZhuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#15008

We only allow an explicit casting in the PR, we can extend the behavior later, but we need that for testing.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang merged commit e6d8d88 into main Feb 22, 2024
26 of 27 checks passed
@TennyZhuang TennyZhuang deleted the feat/explicit-cast-serial-to-bigint branch February 22, 2024 06:10
@ramoncjs3
Copy link

I've currently updated to the latest version v2.0.1 and I still can't get a self-incrementing ID column, I need your help, thanks.

image

As you can see above, I have converted the _row_id column display to a bigint type, but for some reason the id column is still empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants