Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store vnode bitmap in local state store #15183

Merged
merged 11 commits into from
Feb 27, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Feb 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR lets local state store aware of the vnodes it is responsible for by storing vnode bitmap in read version. The vnode bitmap will be initialized during state store init and updated on state table update_vnode_bitmap. This PR also adds an extra assertion on read version to ensure there is no staging uncommitted data on update_vnode_bitmap.

#15099

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

@@ -434,6 +436,7 @@ pub struct MemtableLocalStateStore<S: StateStoreWrite + StateStoreRead> {
table_id: TableId,
op_consistency_level: OpConsistencyLevel,
table_option: TableOption,
vnodes: Option<Arc<Bitmap>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity I think it's unnecessary to store the vnode in this trivial local state store.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't store vnodes in this local state store, I think the assertion in state table to check whether the state table and state store vnode bitmap matches will fail.

src/storage/src/hummock/store/local_hummock_storage.rs Outdated Show resolved Hide resolved
@hzxa21 hzxa21 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 33a9302 Feb 27, 2024
26 of 27 checks passed
@hzxa21 hzxa21 deleted the patrick/local-store-vnode-bitmap branch February 27, 2024 06:17
hzxa21 added a commit that referenced this pull request Mar 29, 2024
hzxa21 added a commit that referenced this pull request Apr 2, 2024
hzxa21 added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants