Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(object store): use AssumeRoleWithWebIdentity for opendal s3 #15182

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Feb 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, we don't need to set ak sk anymore.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from hzxa21 February 21, 2024 10:48
@wcy-fdu wcy-fdu requested a review from wjf3121 February 21, 2024 11:02
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Feb 21, 2024

Verified on s3 and s3-compatible(cos) storage, both work.

@wcy-fdu wcy-fdu enabled auto-merge February 21, 2024 12:05
auto-merge was automatically disabled February 22, 2024 06:09

Merge queue setting changed

@wcy-fdu wcy-fdu added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit b5e3a22 Feb 23, 2024
30 of 31 checks passed
@wcy-fdu wcy-fdu deleted the wcy/opendal_s3_use_role_arn branch February 23, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants