feat(cmd_all): create directories in single_node mode
#15176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Feb 21, 2024
src/cmd_all/src/single_node.rs
Outdated
Comment on lines
308
to
309
| // wait for log messages to be flushed | ||
| tokio::time::sleep(std::time::Duration::from_millis(100)).await; |
There was a problem hiding this comment.
You mean this?
Suggested change
| // wait for log messages to be flushed | |
| tokio::time::sleep(std::time::Duration::from_millis(100)).await; | |
| io::stdout().flush().unwrap(); |
src/cmd_all/src/single_node.rs
Outdated
|
|
||
| // TODO: should we join all handles? | ||
| // Currently, not all services can be shutdown gracefully, just quit on Ctrl-C now. | ||
| // TODO(kwannoel): Why can't be shutdown gracefully? Is it that the service just does not |
There was a problem hiding this comment.
Have you tried joining all handles after receiving signal::ctrl_c? Does it work? I think it would work 🤔
BugenZhao
reviewed
Feb 21, 2024
src/cmd_all/src/bin/risingwave.rs
Outdated
| let settings = risingwave_rt::LoggerSettings::from_opts(&opts) | ||
| .with_target("risingwave_storage", Level::WARN) | ||
| .with_thread_name(true); | ||
| risingwave_rt::init_risingwave_logger(settings); | ||
| risingwave_rt::main_okk(risingwave_cmd_all::standalone(opts)).unwrap(); | ||
| risingwave_rt::main_okk(risingwave_cmd_all::single_node(opts)).unwrap(); |
There was a problem hiding this comment.
May I know the difference between them?
src/cmd_all/src/single_node.rs
Outdated
| // wait for log messages to be flushed | ||
| tokio::time::sleep(std::time::Duration::from_millis(100)).await; | ||
| eprintln!("-------------------------------"); | ||
| eprintln!("RisingWave single_node mode is ready."); |
There was a problem hiding this comment.
Suggested change
| eprintln!("RisingWave single_node mode is ready."); | |
| eprintln!("RisingWave single node mode is ready."); |
|
Will do the refactor another time. Want to get the single node mode ready first. |
|
Will address the review comments in a separate PR, when I refactor Now this PR only contains changes to create the meta store. |
kwannoel
changed the title
kwannoel
changed the title
single_node mode
kwannoel
force-pushed
the
kwannoel/create_meta_store_and_state_store
branch
from
17f6ee4 to
72e2c98
Compare
|
Bump, PTAL @BugenZhao , @fuyufjh , the refactors have been stripped from this PR. Now we just create store directories. |
fuyufjh
changed the title
single_node modesingle_node mode
fuyufjh
approved these changes
Feb 22, 2024
auto-merge was automatically disabled
February 23, 2024 01:45
Merge queue setting changed
kwannoel
force-pushed
the
kwannoel/create_meta_store_and_state_store
branch
from
72e2c98 to
0d1606e
Compare
kwannoel
added a commit
that referenced
this pull request
Feb 24, 2024
kwannoel
added a commit
that referenced
this pull request
Feb 24, 2024
) Co-authored-by: Noel Kwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #15062
Just create
state_store,meta_storedirectories, if they did not exist.The default store directory is:
So by default, the following directories are created:
Checklist
Also separate
single_nodefromstandalone_mode../risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.