Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine sink into table functionalities #15160

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Feb 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. During the recovery process, support for repairing the table sink's dirty downstream is provided.
  2. Return an error when there is a table sink in the cascade dependency chain.
    3. A more refined cycle check.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@shanicky shanicky requested a review from yezizp2012 February 21, 2024 02:19
@shanicky shanicky force-pushed the peng/table-sink-model-v2-recovery branch from 34cde94 to a3ed031 Compare February 21, 2024 07:19
@shanicky shanicky changed the base branch from main to peng/refine-cycle-check February 21, 2024 07:20
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

Base automatically changed from peng/refine-cycle-check to main February 23, 2024 04:21
@shanicky shanicky force-pushed the peng/table-sink-model-v2-recovery branch from 1e56fcd to ad3bf1d Compare February 23, 2024 04:52
@shanicky shanicky enabled auto-merge February 23, 2024 04:53
@shanicky shanicky force-pushed the peng/table-sink-model-v2-recovery branch from ad3bf1d to ed1a340 Compare February 23, 2024 05:17
@shanicky shanicky added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit bd29148 Feb 23, 2024
27 checks passed
@shanicky shanicky deleted the peng/table-sink-model-v2-recovery branch February 23, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants