refactor(stream): own and recreate shared context and local barrier manager in recovery #15157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
requested review from
hzxa21,
yezizp2012,
BugenZhao,
kwannoel and
zwang28
9 tasks
BugenZhao
reviewed
Feb 27, 2024
e2e_test/batch/transaction/now.slt
Outdated
Comment on lines
30
to
34
| query T | ||
| select * from v | ||
| except | ||
| select * from mv; | ||
| ---- |
There was a problem hiding this comment.
I think we can still keep this one. 😄
BugenZhao
reviewed
Feb 27, 2024
| manager | ||
| .send_barrier(barrier.clone(), actor_ids_to_send, actor_ids_to_collect) | ||
| actor_op_tx | ||
| .send_and_await(|tx| LocalActorOperation::InjectBarrier { |
There was a problem hiding this comment.
Can we still extracting it as a method? Same for AwaitEpochCommited.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Currently we have
SharedContextandLocalBarrierManagerthat are created at CN initialization and then exists in long run.SharedContextis for actors to communicate and exchange information, and it gets cleared in every recovery.LocalBarrierManageris used for actors to send barrier related event to barrier worker loop via a channel. However, the same channel is still used after recovery, and it's possible that there is some stale actor events sent after the reset event are stored in the channel and get handled after recovery, which may caused bug. Therefore, theLocalBarrierManagershould also be cleared in recovery.Since both
SharedContextandLocalBarrierManagershould be cleared in recovery, it's better to just recreate them and let the actors created after recovery to use the new ones. Therefore, in this PR, we change to own the shared context and local barrier manager in the barrier worker loop, and we will recreate them in recovery.The current
LocalBarrierEventmixes the events reported by actor and the requests sent from stream manager. In this PR we split the request sent from stream manager to a separate enum namedLocalActorOperation. The stream manager no longer send request viaLocalBarrierManager, but instead holds its own channel to send request to local barrier worker loop. TheLocalBarrierManageris owned in the barrier worker loop, and pass to actor during actor creation.Previously the stream manager also holds a reference to
SharedContextto handle some rpc request. In this PR we change to handle the rpc request via sending a request to barrier worker loop and wait for result.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.