-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink demo): Add http sink demo #15149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, so the http server in this demo needs to be activated by the user on their own, right?
cc: @neverchanje
I was unaware about the feature so I didn't know you have actually implemented some stuff. IMO Getindata's http sink has a few limitations:
To conclude, the SQL interface can only work in certain cases where the REST API is session-less and simple. For more general cases, I would suggest users to try Python UDF at first. In the cloud environment, this solution will only require exposing the UDF server to the public network, which will be more secured. |
I agree, this feature was just a small example at the time when it was compatible with flink sink, the purpose of this pr was just that we didn't have an example of this feature anywhere in our library, so it was added. |
Can we document this as well as the limitation of the current http sink implementation in the demo code and flink sink code? |
Merge queue setting changed
Merge queue setting changed
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add an http sink demo
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.