Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set buf breaking rule back to WIRE_JSON #15147

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #15030 for the background.

Again, the check is not enforced in CI. We can safely ignore it...

  • if the message is never persisted,
  • or any time before the SQL meta store is released and marked as stable.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Feb 20, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@xxchan xxchan enabled auto-merge February 20, 2024 08:12
auto-merge was automatically disabled February 22, 2024 06:09

Merge queue setting changed

@BugenZhao BugenZhao added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit ea0b012 Feb 23, 2024
31 of 32 checks passed
@BugenZhao BugenZhao deleted the bz/buf-breaking-wire-json branch February 23, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants