Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): a new block cache strategy FIFO #15129

Closed
wants to merge 12 commits into from

Conversation

Little-Wallace
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This idea comes from https://jasony.me/publication/sosp23-s3fifo.pdf in SOSP-23.
The new strategy propose two cache component to store new inserted data(named S) and hot data (named M).
If an entry has been read by several times it will be pushed to M, otherwise it will be evicted. But this paper proposes an extra structure (named G) to store some evicted keys. If these keys are requested again before they are evicted from G, they would be pushed to M, too.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace changed the title feat(storage): a new block cache strategy feat(storage): a new block cache strategy FIFO Feb 19, 2024
@Little-Wallace Little-Wallace marked this pull request as ready for review February 21, 2024 12:19
@Little-Wallace Little-Wallace requested a review from a team as a code owner February 21, 2024 12:19
Signed-off-by: Little-Wallace <[email protected]>
@hzxa21
Copy link
Collaborator

hzxa21 commented Feb 26, 2024

The idea looks promising! How about:

  1. Run micro-benchmark to compare the overhead for S3-FIFO and LRU.
  2. Run perf test to compare the cache efficiency for S3-FIFO and LRU.

Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace
Copy link
Contributor Author

It did not approve anything.
We will retry this algorithm after implement it with cache interface.
Some other contributor also give an implementation of this algorithm: foyer-rs/foyer#303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants