Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): concurrent fetch for temporal join (take 2) #15115

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Feb 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previous try: Close #14666

Close #13974

Rework without any rust tricks :)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@TennyZhuang
Copy link
Contributor Author

15115-q13-benchmark

No performance downgrade.

Due to the good locality of nexmark, we can't see a performance improvement.

@st1page
Copy link
Contributor

st1page commented Feb 19, 2024

Due to the good locality of nexmark, we can't see a performance improvement.

#15124

Signed-off-by: TennyZhuang <[email protected]>
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang
Copy link
Contributor Author

image

When the dimensional table (10k records, q13) is all in memory, this PR did not bring significant performance loss (within the fluctuation range).
When the dimensional table (1b records, q13) experiences high cache misses, this PR brought a fivefold performance improvement.

I believe merging it is worthwhile.

@TennyZhuang TennyZhuang added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 59ce8df Feb 23, 2024
36 of 37 checks passed
@TennyZhuang TennyZhuang deleted the concurrent-temporal-join-take-2 branch February 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: temporal join look up concurrently
4 participants