Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc-backfill): ensure snapshot read once for each epoch #15079

Merged
merged 5 commits into from
Feb 11, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Feb 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Inspired by #12780

Will pick to main later.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW force-pushed the siyuan/wkx-jindo-hotfix branch from e26a7ec to 684677b Compare February 11, 2024 08:00
@StrikeW StrikeW requested a review from st1page February 11, 2024 08:03
@StrikeW StrikeW changed the title feat(cdc-backfill): ensure snapshot read once for each epoch fix(cdc-backfill): ensure snapshot read once for each epoch Feb 11, 2024
@github-actions github-actions bot added type/fix Bug fix and removed type/feature labels Feb 11, 2024
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick patch but when PR to the main branch, I guess we need reuse some common code.

src/stream/src/executor/backfill/cdc/cdc_backfill.rs Outdated Show resolved Hide resolved
@StrikeW StrikeW force-pushed the siyuan/wkx-jindo-hotfix branch from 55da32f to d65d117 Compare February 11, 2024 09:56
@StrikeW StrikeW merged commit d7bf4e6 into wkx/jindo-hotfix-udf-call-timeout Feb 11, 2024
30 of 31 checks passed
@StrikeW StrikeW deleted the siyuan/wkx-jindo-hotfix branch February 11, 2024 11:48
StrikeW added a commit that referenced this pull request Feb 11, 2024
@kwannoel
Copy link
Contributor

Why does cdc backfill also encounter this issue? Upstream DB should not have tombstones

@kwannoel
Copy link
Contributor

Or is there some other motivation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants