Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): improve planner test suite for case when & add const evaluation test #15077

Merged
merged 18 commits into from
Feb 27, 2024

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Feb 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled, should merge after #14965.

Note that the base branch is set to #14965 just to avoid any potential merge conflict. 😄

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xzhseh xzhseh self-assigned this Feb 11, 2024
@xzhseh xzhseh requested a review from Li0k February 11, 2024 01:51
Base automatically changed from xzhseh/case-when-optimizer-rewrite-rule to main February 23, 2024 16:16
@xzhseh
Copy link
Contributor Author

xzhseh commented Feb 26, 2024

What about merging this PR, so that #15083 could also be reviewed & merged, cc @st1page @chenzl25.

@xzhseh xzhseh added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 467551c Feb 27, 2024
8 of 9 checks passed
@xzhseh xzhseh deleted the xzhseh/const-case-when-planner-test branch February 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants