Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pg_database e2e to make it compatible with sql-backend #15059

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Feb 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #15058 .

In sql-backend, the id of database is starting from 1 but in etcd it's 0.

To make the test compatible, just check the database name, since that's the same across the backends.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Feb 8, 2024
@kwannoel
Copy link
Contributor

kwannoel commented Feb 8, 2024

Thanks for the PR, Could you elaborate more? Why is there a system catalog results mismatch?

@yezizp2012
Copy link
Member Author

Thanks for the PR, Could you elaborate more? Why is there a system catalog results mismatch?

In sql-backend, the id of database is starting from 1 but in etcd it's 0.

@yezizp2012 yezizp2012 added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 7cbf16a Feb 8, 2024
32 of 33 checks passed
@yezizp2012 yezizp2012 deleted the fix/pg-database-e2e branch February 8, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog test failed: e2e_test/visibility_mode/../batch/./catalog/pg_database.slt.part
3 participants