Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration_tests): separate test for arrangement backfill cancel with high barrier latency #15011

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

When there's high barrier latency, test that arrangement backfill can be cancelled.

The fix ensures there's some progress, to ensure latency is high when we issue a cancel command. Otherwise the cancel command will succeed quickly.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/test Test related issue. label Feb 5, 2024
@kwannoel kwannoel changed the title test: add test for arrangement backfill recovery test: add test for arrangement backfill cancel with high barrier latency Feb 5, 2024
@kwannoel kwannoel changed the title test: add test for arrangement backfill cancel with high barrier latency fix(integration_tests): separate test for arrangement backfill cancel with high barrier latency Feb 5, 2024
@github-actions github-actions bot added type/fix Bug fix and removed component/test Test related issue. labels Feb 5, 2024
@kwannoel kwannoel requested a review from chenzl25 February 6, 2024 02:22
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@kwannoel kwannoel added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 8735491 Feb 7, 2024
30 of 31 checks passed
@kwannoel kwannoel deleted the kwannoel/high-barrier-fix branch February 7, 2024 05:25
yezizp2012 pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants