fix: only processing streaming jobs that are in the 'created' state in auto-scaling #15000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
added
ci/run-main-cron
ci/run-build-simulation
ci/run-recovery-test-deterministic-simulation
and removed
type/fix
shanicky
commented
Feb 5, 2024
| @@ -751,6 +754,7 @@ impl GlobalBarrierManagerContext { | |||
| guard | |||
| .table_fragments() | |||
| .iter() | |||
| .filter(|&(_, table)| matches!(table.state(), State::Created)) | |||
There was a problem hiding this comment.
for auto scale in recovery (scale in & scale down)
There was a problem hiding this comment.
In the future perhaps we will permit scaling for background ddl 🤔 . Perhaps we should add a comment for it.
There was a problem hiding this comment.
Good catch, filtering by Running actors should work.
| @@ -2528,6 +2528,7 @@ impl GlobalStreamManager { | |||
| guard | |||
| .table_fragments() | |||
| .iter() | |||
| .filter(|&(_, table)| matches!(table.state(), State::Created)) | |||
There was a problem hiding this comment.
for auto scale in normal scenario (scale up & scale out)
yezizp2012
approved these changes
Feb 5, 2024
kwannoel
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, related #14992 .
Checklist
./risedev check(or alias,./risedev c)