Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql-backend): fix some corner cases in alter rename and schema in sql backend #14982

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Feb 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixed some bugs when running e2e for alter rename and alter schema in SQL backend.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 requested a review from shanicky February 4, 2024 11:10
@github-actions github-actions bot added the type/fix Bug fix label Feb 4, 2024
@yezizp2012 yezizp2012 changed the title fix: fix some corner cases in alter rename schema in sql backend fix(sql-backend): fix some corner cases in alter rename schema in sql backend Feb 4, 2024
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

src/frontend/src/observer/observer_manager.rs Outdated Show resolved Hide resolved
Co-authored-by: Shanicky Chen <[email protected]>
@yezizp2012 yezizp2012 changed the title fix(sql-backend): fix some corner cases in alter rename schema in sql backend fix(sql-backend): fix some corner cases in alter rename and schema in sql backend Feb 4, 2024
@yezizp2012 yezizp2012 enabled auto-merge February 4, 2024 11:34
@yezizp2012 yezizp2012 added this pull request to the merge queue Feb 4, 2024
Merged via the queue into main with commit fd2a899 Feb 4, 2024
32 of 33 checks passed
@yezizp2012 yezizp2012 deleted the fix/fix-corner-case-alter branch February 4, 2024 11:51
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
yezizp2012 pushed a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants