Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try fix the issue where dirty actors cause debug checks to fail during the auto-scaling process. #14978

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: try fix the issue where dirty actors cause debug checks to fail during the auto-scaling process. #14978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/meta/src/stream/scale.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,16 +1732,21 @@ impl ScaleController {
"no shuffle should have exactly one downstream actor id",
);

let downstream_fragment_id = actor_fragment_id_map_for_check
.get(downstream_actor_id)
.unwrap();

// dispatcher_id of dispatcher should be exactly same as downstream fragment id
// but we need to check it to make sure
debug_assert_eq!(
*downstream_fragment_id,
dispatcher.dispatcher_id as FragmentId
);
if let Some(downstream_fragment_id) =
actor_fragment_id_map_for_check.get(downstream_actor_id)
{
// dispatcher_id of dispatcher should be exactly same as downstream fragment id
// but we need to check it to make sure
debug_assert_eq!(
*downstream_fragment_id,
dispatcher.dispatcher_id as FragmentId
);
} else {
tracing::warn!(
"downstream actor id {} not found in fragment_actor_id_map",
downstream_actor_id
);
}

no_shuffle_target_fragment_ids
.insert(dispatcher.dispatcher_id as FragmentId);
Expand Down
Loading