-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(meta): merge periodic and scheduled barrier and non-async handle barrier #14977
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
0a434f1
to
61162e3
Compare
61162e3
to
ce28905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Currently in the
select!
of global barrier worker loop, we only get notified on newly scheduled barrier, but we only pop the barrier when we callhandle_new_barrier
. In this PR, we change to merged the logic of periodic barriers and scheduled barriers into anext_barrier
method that emits the next barrier, and we pass the new barrier tohandle_new_barrier
to be handled.Furthermore, currently in
handle_new_barrier
, we in place wait forinject_barrier
to finish before spawning a task to callcollect_barrier
. In this PR we change to spawn the task directly to handle bothinject_barrier
andcollect_barrier
.After these changes, the
handle_new_barrier
method gets non-async and non-blocking.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.