-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(binder): add const case-when evaluation optimization during binding #14965
Merged
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
03c3f69
add const_case_when_eval_rule & const_case_when_rewriter
xzhseh 33f49b8
add constant case when evaluation pass
xzhseh 2d2f412
add rewrite rule
xzhseh 4d9cd6c
fix format
xzhseh 4c0015f
remove unnecessary expr in expr.proto
xzhseh 6fad732
add comment to best illustrate the purpose
xzhseh a650318
fix check
xzhseh 25c292d
better format
xzhseh 67e90fa
fix check
xzhseh e45675b
add more comments
xzhseh 7ac22ce
update planner test
xzhseh e18b44a
remove redundant optimization rewrite rule
xzhseh e68e53c
update planner tests
xzhseh e1be234
Merge branch 'main' into xzhseh/case-when-optimizer-rewrite-rule
xzhseh 0de1afa
Merge branch 'main' into xzhseh/case-when-optimizer-rewrite-rule
xzhseh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/frontend/src/optimizer/plan_expr_rewriter/const_case_when_rewriter.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright 2024 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use risingwave_common::error::RwError; | ||
|
||
use crate::expr::{ExprImpl, ExprRewriter, ExprType, FunctionCall}; | ||
|
||
pub struct ConstCaseWhenRewriter { | ||
pub error: Option<RwError>, | ||
} | ||
|
||
impl ExprRewriter for ConstCaseWhenRewriter { | ||
fn rewrite_function_call(&mut self, func_call: FunctionCall) -> ExprImpl { | ||
if func_call.func_type() != ExprType::ConstantLookup { | ||
return func_call.into(); | ||
} | ||
if func_call.inputs().len() != 1 { | ||
// Normal constant lookup pass | ||
return func_call.into(); | ||
} | ||
func_call.inputs()[0].clone().into() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/frontend/src/optimizer/rule/const_case_when_eval_rule.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// Copyright 2024 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use super::super::plan_node::*; | ||
use super::{BoxedRule, Rule}; | ||
use crate::optimizer::plan_expr_rewriter::ConstCaseWhenRewriter; | ||
|
||
pub struct ConstCaseWhenEvalRule {} | ||
impl Rule for ConstCaseWhenEvalRule { | ||
fn apply(&self, plan: PlanRef) -> Option<PlanRef> { | ||
let values: &LogicalValues = plan.as_logical_values()?; | ||
let mut const_case_when_rewriter = ConstCaseWhenRewriter { error: None }; | ||
Some(values.rewrite_exprs(&mut const_case_when_rewriter)) | ||
} | ||
} | ||
|
||
impl ConstCaseWhenEvalRule { | ||
pub fn create() -> BoxedRule { | ||
Box::new(ConstCaseWhenEvalRule {}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I create another check function is that we can't check all the optimizable case-when patterns within only one pass, and they indeed have subtle but significant difference, which may not be generalized.