refactor(test): refactor sql udf test #14941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangrunji0408
approved these changes
Feb 2, 2024
xxchan
approved these changes
Feb 2, 2024
e2e_test/udf/sql_udf.slt
Outdated
| # create materialized view foo_mv as select fib(100); | ||
|
|
||
| # Calling a non-existence function | ||
| statement error failed to conduct semantic check, please see if you are calling non-existence functions |
e2e_test/udf/sql_udf.slt
Outdated
| @@ -1,325 +1,346 @@ | |||
| statement ok | |||
| SET RW_IMPLICIT_FLUSH TO true; | |||
|
|
|||
| ############################################# | |||
| # Basic tests for anonymous / named sql udf # | |||
There was a problem hiding this comment.
I think anonymous function means function without a name. usually a closure. Better to just call them functions with named parameters.
There was a problem hiding this comment.
I think unnamed / named sql udf is a good choice then. 😄
There was a problem hiding this comment.
"unnamed" is still "anonymous"'s synonyms.. Please try to avoid making up terms that may lead to confusion.
There was a problem hiding this comment.
Then let's just stick with "sql udf with [named / unnamed] parameters", which should be precise and clear in most contexts.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled, refactor the current sql udf test suite to five sections, to improve the readability & future maintainability.
See the updated test for details.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Just a reminder of the naming convention of sql udf, now we will stick with: SQL udf with [unnamed / named] parameters, instead of the original [anonymous / named] sql udf. The documentation may be updated accordingly.
Reference: #14941 (comment).