-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type): improve the Fields
derive macro
#14934
Merged
+208
−41
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4a0b3bc
add primary key and into_owned_row to `Fields` trait
wangrunji0408 c2c3b44
fix `r#` in field name
wangrunji0408 d801f82
support `ToOwnedDatum` for `Vec<Option<F32>>`
wangrunji0408 74cd287
Merge remote-tracking branch 'origin/main' into wrj/derive-fields
wangrunji0408 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Merge remote-tracking branch 'origin/main' into wrj/derive-fields
Signed-off-by: Runji Wang <wangrunji0408@163.com>
- Loading branch information
commit 74cd28749e1fb566276ba3e65c01e95be513c568
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'd prefer introducing a new trait for doing such conversion. By
ToOwnedDatum
I suppose it's only for the conversion from the ref type to an owned type, just like the std'sToOwned
trait with GAT support.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But logically types
impl Into<ScalarImpl>
can be convertedToOwnedDatum
. I think it would be convenient to reuse this trait.