Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): reset to the latest committed epoch in recovery #14923

Merged
merged 10 commits into from
Feb 19, 2024

resolve comment

99f543b
Select commit
Loading
Failed to load commit list.
Merged

feat(storage): reset to the latest committed epoch in recovery #14923

resolve comment
99f543b
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-02-19 06:40:26 ago

1 / 8 tasks completed

7 tasks still to be completed

Details

Required Tasks

Task Status
pass prev_epoch in the force_stop_actors rpc and pass it all the way down to where we actually handle the storage clear in event handler. Incomplete
add prev_epoch parameter in the clear_shared_buffer, and change its return type from StorageResult<()> to () Incomplete
use a separate channel to get notified on version update, where we previously reuse the channel for hummock event Incomplete
when handling clear event, we will drain the cache refiller and apply its pending version update if there is any. If the committed epoch is still below the global one, keep waiting for further version update notification until reaching the global one. Incomplete
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
Understand the implications of revoking this secret by investigating where it is used in your code. Incomplete
Replace and store your secret safely. Learn here the best practices. Incomplete
Revoke and rotate this secret. Incomplete
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. Incomplete
following these best practices for managing and storing secrets including API keys and other credentials Incomplete
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation. Incomplete
in recovery we can save an extra rpc to wait for the local mce to bump up to global one. Incomplete
avoid waiting for cache refill finish during recovery. Incomplete