-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename prometheus_host
to prometheus_listener_addr
#14919
Conversation
BTW, I found that the Prometheus-backed metrics on dashboard doesn't work in our testing environment. Need to fix cc. @BugenZhao |
Can you elaborate more on "testing env"? |
Oh I mean the longevity test actually, but I suppose it should apply to all environments that provisioned by kube-bench or our risingwave-operator. |
prometheus
addressesprometheus_host
to prometheus_listener_addr
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As per title.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.