Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename prometheus_host to prometheus_listener_addr #14919

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/doc Issues about documentation. label Feb 1, 2024
@kwannoel kwannoel enabled auto-merge February 1, 2024 07:27
@fuyufjh
Copy link
Member

fuyufjh commented Feb 1, 2024

BTW, I found that the Prometheus-backed metrics on dashboard doesn't work in our testing environment. Need to fix cc. @BugenZhao

@BugenZhao
Copy link
Member

BTW, I found that the Prometheus-backed metrics on dashboard doesn't work in our testing environment. Need to fix cc. @BugenZhao

Can you elaborate more on "testing env"?

src/meta/node/src/lib.rs Outdated Show resolved Hide resolved
@fuyufjh
Copy link
Member

fuyufjh commented Feb 1, 2024

BTW, I found that the Prometheus-backed metrics on dashboard doesn't work in our testing environment. Need to fix cc. @BugenZhao

Can you elaborate more on "testing env"?

Oh I mean the longevity test actually, but I suppose it should apply to all environments that provisioned by kube-bench or our risingwave-operator.

@kwannoel kwannoel added this pull request to the merge queue Feb 1, 2024
@BugenZhao BugenZhao removed this pull request from the merge queue due to a manual request Feb 1, 2024
@kwannoel kwannoel changed the title doc: update docs for prometheus addresses refactor: rename prometheus_host to prometheus_listener_addr Feb 1, 2024
@kwannoel kwannoel enabled auto-merge February 1, 2024 09:12
@github-actions github-actions bot added type/refactor and removed component/doc Issues about documentation. labels Feb 1, 2024
@kwannoel kwannoel added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2024
@kwannoel kwannoel added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2024
@kwannoel kwannoel added this pull request to the merge queue Feb 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 2, 2024
@kwannoel kwannoel added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 8fdd0ba Feb 2, 2024
26 of 27 checks passed
@kwannoel kwannoel deleted the kwannoel/doc-prom branch February 2, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants