fix(sql-udf): correctly handle udf_binding_flag & udf_global_count
#14906
Conversation
| @@ -204,7 +208,7 @@ pub async fn handle_create_sql_function( | |||
| } | |||
| } | |||
| Err(e) => return Err(ErrorCode::InvalidInputSyntax(format!( | |||
| "failed to conduct semantic check, please see if you are calling non-existence functions: {}", | |||
| "failed to conduct semantic check, please see if you are calling non-existence functions or parameters\ndetailed error message: {}", | |||
There was a problem hiding this comment.
This is just a current work around, I prefer a better hint display in the future, related: #14853.
| if self.udf_context.global_count() == 0 { | ||
| self.unset_udf_binding_flag(); | ||
| } |
There was a problem hiding this comment.
Looks like udf_binding_flag can be inferred by udf_global_counter != 0. Can we remove udf_binding_flag now?
There was a problem hiding this comment.
I think so, let me do a tiny refactor.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | dc1b7c2 | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fixed a subtle but somewhat critical bug in the current sql udf implementation.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Just a note for docs to cover the named sql udf use case as demonstrated in the update test.