Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): remove delete range runner test #14889

Merged
merged 3 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/scripts/cron-e2e-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ set -euo pipefail
source ci/scripts/common.sh
export RUN_COMPACTION=0;
export RUN_META_BACKUP=1;
export RUN_DELETE_RANGE=1;
source ci/scripts/run-e2e-test.sh
4 changes: 1 addition & 3 deletions ci/scripts/pr.env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@ set -euo pipefail
# Don't run e2e compaction test in PR build
export RUN_COMPACTION=0;
# Don't run meta store backup/recovery test
export RUN_META_BACKUP=0;
# Don't run delete-range random test
export RUN_DELETE_RANGE=0;
export RUN_META_BACKUP=0;
16 changes: 0 additions & 16 deletions ci/scripts/run-e2e-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,22 +133,6 @@ RUST_BACKTRACE=1 target/debug/risingwave_e2e_extended_mode_test --host 127.0.0.1
echo "--- Kill cluster"
cluster_stop

if [[ "$RUN_DELETE_RANGE" -eq "1" ]]; then
echo "--- e2e, ci-delete-range-test"
cargo make clean-data
RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
cargo make ci-start ci-delete-range-test
download-and-decompress-artifact delete-range-test-"$profile" target/debug/
mv target/debug/delete-range-test-"$profile" target/debug/delete-range-test
chmod +x ./target/debug/delete-range-test

config_path=".risingwave/config/risingwave.toml"
./target/debug/delete-range-test --ci-mode --state-store hummock+minio://hummockadmin:[email protected]:9301/hummock001 --config-path "${config_path}"

echo "--- Kill cluster"
cluster_stop
fi

if [[ "$RUN_COMPACTION" -eq "1" ]]; then
echo "--- e2e, ci-compaction-test, nexmark_q7"
RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
Expand Down
5 changes: 0 additions & 5 deletions risedev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -862,11 +862,6 @@ profile:
- use: etcd
- use: minio

ci-delete-range-test:
config-path: src/config/ci-delete-range-test.toml
steps:
- use: minio

ci-iceberg-test:
config-path: src/config/ci-iceberg-test.toml
steps:
Expand Down
8 changes: 0 additions & 8 deletions src/config/ci-delete-range-test.toml

This file was deleted.

9 changes: 0 additions & 9 deletions src/tests/compaction_test/Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,3 @@ script = """
set -e
cargo run --bin compaction-test --profile "${RISINGWAVE_BUILD_PROFILE}" -- "$@"
"""

[tasks.delete-range-test]
category = "RiseDev - Test"
description = "Run hummock compaction delete-range for test"
script = """
#!/usr/bin/env bash
set -e
cargo run --bin delete-range-test --profile "${RISINGWAVE_BUILD_PROFILE}" -- "$@"
"""
1 change: 1 addition & 0 deletions src/tests/compaction_test/src/bin/delete_range.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#[cfg_attr(coverage, coverage(off))]
fn main() {
// Since we decide to record watermark in every state-table to replace delete-range, this test is not need again. We keep it because we may need delete-range in some day for other features.
use clap::Parser;

let opts = risingwave_compaction_test::CompactionTestOpts::parse();
Expand Down
Loading