-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: More integrations tests for jni catalog. #14885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4780 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2073 | 5 | 2702 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynClasses.java
- java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynConstructors.java
- java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynFields.java
- java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynMethods.java
- java/connector-node/risingwave-sink-iceberg/src/test/java/com/risingwave/connector/catalog/JniCatalogWrapperTest.java
...nnector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynClasses.java
Show resolved
Hide resolved
...or-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynConstructors.java
Show resolved
Hide resolved
...onnector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynFields.java
Show resolved
Hide resolved
...nnector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynMethods.java
Show resolved
Hide resolved
...gwave-sink-iceberg/src/test/java/com/risingwave/connector/catalog/JniCatalogWrapperTest.java
Show resolved
Hide resolved
c39daf9
to
aad5701
Compare
This PR is ready for review. |
e75952b
to
9f0e557
Compare
126aa37
to
0f3128d
Compare
cc @chenzl25 @tabVersion @wenym1 @ZENOTME PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
0f3128d
to
490090c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM. Thanks!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add more integration tests for jni catalog.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.