Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: More integrations tests for jni catalog. #14885

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Jan 31, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add more integration tests for jni catalog.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@liurenjie1024 liurenjie1024 marked this pull request as draft January 31, 2024 01:52
@github-actions github-actions bot added the component/test Test related issue. label Jan 31, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 4780 files.

Valid Invalid Ignored Fixed
2073 5 2702 0
Click to see the invalid file list
  • java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynClasses.java
  • java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynConstructors.java
  • java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynFields.java
  • java/connector-node/risingwave-sink-iceberg/src/main/java/org/apache/iceberg/common/DynMethods.java
  • java/connector-node/risingwave-sink-iceberg/src/test/java/com/risingwave/connector/catalog/JniCatalogWrapperTest.java

@liurenjie1024 liurenjie1024 marked this pull request as ready for review February 22, 2024 08:22
@liurenjie1024
Copy link
Contributor Author

This PR is ready for review.

@liurenjie1024
Copy link
Contributor Author

cc @chenzl25 @tabVersion @wenym1 @ZENOTME PTAL

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

src/connector/src/sink/iceberg/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Thanks!

@liurenjie1024 liurenjie1024 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 5bac8e7 Feb 27, 2024
32 of 33 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-13900-2 branch February 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants