Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): avoid anyhow in AccessError and avoid using RwError if possible #14874

Merged
merged 3 commits into from
Feb 1, 2024

resolve comments

695d5f9
Select commit
Loading
Failed to load commit list.
Merged

refactor(connector): avoid anyhow in AccessError and avoid using RwError if possible #14874

resolve comments
695d5f9
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-02-01 06:34:58 ago

3 / 4 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
Avoid anyhow in AccessError, as it's used in parsing and capturing backtraces per record is not acceptable in performance. This PR uses a plain String instead and provide similar experience to anyhow for constructing leaf errors by thiserror_ext::Macro. Incomplete
Use AccessError as much as possible for parsing-related code logic, instead of using RwError. Incomplete
I have written necessary rustdoc comments Completed
I have added necessary unit tests and integration tests Completed
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete