Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): improve actor info & source throughput panels #14870

Merged
merged 10 commits into from
Feb 1, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jan 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Updated these 4 panels in both user and dev dashboard.

image

Note: Added the fragmend_id label to source throughput because there is one SourceExecutor for each streaming job.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested review from tabVersion and wcy-fdu January 30, 2024 08:22
@fuyufjh fuyufjh changed the title enhance(grafana): improve grafana dashboard: actor info & source throughput feat(grafana): improve actor info & source throughput panels Jan 30, 2024
@fuyufjh fuyufjh enabled auto-merge February 1, 2024 03:36
@fuyufjh fuyufjh added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 20fc879 Feb 1, 2024
9 of 19 checks passed
@fuyufjh fuyufjh deleted the eric/improve_grafana_dashboard branch February 1, 2024 06:56
@fuyufjh fuyufjh mentioned this pull request Feb 1, 2024
9 tasks
TennyZhuang pushed a commit that referenced this pull request Feb 2, 2024
TennyZhuang pushed a commit that referenced this pull request Feb 2, 2024
TennyZhuang pushed a commit that referenced this pull request Feb 2, 2024
TennyZhuang pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants