Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): add back_pressure_rate UI #14863
feat(dashboard): add back_pressure_rate UI #14863
Changes from 14 commits
bd213e5
2f1a053
9ae89d7
62c0bea
1cb5a83
28b20bf
c6b3073
4e0138e
eec1389
37b4b93
fbc0e59
67480d7
acfe6ad
5ab8509
8d96ac2
ae7d7ba
0e2b6a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move it to another path such as "embedded_metrics" or sth? It's mixed with the metrics fetched from Prometheus, which looks confusing to me.
risingwave/src/meta/src/dashboard/mod.rs
Lines 423 to 428 in ae7d7ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw,
/metrics/actor/back_pressures
actually output fragment-level metrics instead of actor-level... 😂 Legacy issuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will solve the problem in a seperate PR