-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add metrics for compaction result check #14860
Conversation
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
|
||
let compaction_result_check_count = register_int_counter_vec_with_registry!( | ||
"storage_compaction_result_check_count", | ||
"KBs read from current level during history compactions to next level", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be modified accordingly.
@@ -504,6 +504,7 @@ pub fn start_compactor( | |||
tracing::warn!(error = %e.as_report(), "Failed to report task {task_id:?}"); | |||
} | |||
if enable_check_compaction_result && need_check_task { | |||
context.compactor_metrics.compaction_result_check_count.with_label_values(&["compaction"]).inc(); | |||
match check_compaction_result(&compact_task, context.clone()).await { | |||
Err(e) => { | |||
tracing::warn!(error = %e.as_report(), "Failed to check compaction task {}",compact_task.task_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a metric to record failure happen in the check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in shared_buffer_compact.rs L269
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
This problem has been solved by other PR |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.