fix(optimizer): fix temporal join shuffle #14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
reviewed
Jan 29, 2024
| &RequiredDist::shard_by_key(self.left().schema().len(), &left_dist_key), | ||
| ctx, | ||
| )? | ||
| RequiredDist::shard_by_key(self.left().schema().len(), &left_dist_key) |
There was a problem hiding this comment.
Not sure if it is ok. why is it not be RequiredDist::PhysicalDist(Distribution::HashShard(left_dist_key))
There was a problem hiding this comment.
Oh, I get it, because it is enforce instead of enforce_if_not_satisfy...
There was a problem hiding this comment.
Use RequiredDist::hash_shard instead.
st1page
approved these changes
Jan 29, 2024
chenzl25
added a commit
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Dylan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.