-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stream): read exactly 1 row if no snapshot read per barrier for arrangement backfill #14842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kwannoel
changed the title
feat(stream): exactly 1 row if no snapshot read per barrier
feat(stream): read exactly 1 row if no snapshot read per barrier
Jan 29, 2024
Could you please also fill the PR body? |
Updated, sorry about that. |
…backfill-tombstone
IIUC this is similar to #14544 but for the arrangement backfill. Would you show that in the PR title? |
kwannoel
changed the title
feat(stream): read exactly 1 row if no snapshot read per barrier
feat(stream): read exactly 1 row if no snapshot read per barrier for arrangement backfill
Jan 31, 2024
chenzl25
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
auto-merge was automatically disabled
January 31, 2024 23:49
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The main idea is: #12780.
If there's a large number of tombstones, backfill snapshot read takes a long time to read an actual record. When barrier comes, the tombstone iterator's progress is dropped. Then backfill's snapshot read will stall and be unable to make progress.
So we just make sure per barrier we read at least 1 record, to avoid the stall scenario.
As to why 1 row instead of 1 chunk, you can see #14544. See the closed issue for more details: #14077
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.