Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): read exactly 1 row if no snapshot read per barrier for arrangement backfill #14842

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jan 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The main idea is: #12780.

If there's a large number of tombstones, backfill snapshot read takes a long time to read an actual record. When barrier comes, the tombstone iterator's progress is dropped. Then backfill's snapshot read will stall and be unable to make progress.

So we just make sure per barrier we read at least 1 record, to avoid the stall scenario.

As to why 1 row instead of 1 chunk, you can see #14544. See the closed issue for more details: #14077

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel marked this pull request as ready for review January 29, 2024 14:22
@kwannoel kwannoel mentioned this pull request Jan 29, 2024
22 tasks
@kwannoel kwannoel changed the title feat(stream): exactly 1 row if no snapshot read per barrier feat(stream): read exactly 1 row if no snapshot read per barrier Jan 29, 2024
@kwannoel
Copy link
Contributor Author

snapshot read
Screenshot 2024-01-30 at 11 21 23 AM

snapshot read + upstream (arrangement backfill)
Screenshot 2024-01-30 at 11 21 43 AM

snapshot read + upstream (no shuffle backfill)
Screenshot 2024-01-30 at 11 21 54 AM

@BugenZhao
Copy link
Member

Could you please also fill the PR body?

@kwannoel
Copy link
Contributor Author

Could you please also fill the PR body?

Updated, sorry about that.

@BugenZhao
Copy link
Member

IIUC this is similar to #14544 but for the arrangement backfill. Would you show that in the PR title?

@kwannoel kwannoel changed the title feat(stream): read exactly 1 row if no snapshot read per barrier feat(stream): read exactly 1 row if no snapshot read per barrier for arrangement backfill Jan 31, 2024
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kwannoel kwannoel enabled auto-merge January 31, 2024 07:18
auto-merge was automatically disabled January 31, 2024 23:49

Merge queue setting changed

@kwannoel kwannoel added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit f21fb9b Feb 1, 2024
29 of 31 checks passed
@kwannoel kwannoel deleted the kwannoel/arrangement-backfill-tombstone branch February 1, 2024 04:36
StrikeW added a commit that referenced this pull request Feb 4, 2024
…ier for arrangement backfill (#14842)"

This reverts commit f21fb9b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants