-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Add Create subscription in frontend #14831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4757 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2067 | 1 | 2689 | 0 |
Click to see the invalid file list
- src/frontend/src/optimizer/mod.rs
e672c82
to
8d31998
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9425213 | Triggered | Generic Password | eacebbe | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit concerned with a 2.3K LoC PR with zero test :(
Is it possible to split it into smaller PRs and add some tests (at least e2e tests).
proto/stream_plan.proto
Outdated
@@ -727,6 +720,12 @@ message OverWindowNode { | |||
OverWindowCachePolicy cache_policy = 5; | |||
} | |||
|
|||
message SubscriptionNode { | |||
catalog.Subscription subscription_catalog = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: the breaking changes here are acceptable because Subscription feature is not released and no one is using it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yesyes
e5ef12b
to
1237d9f
Compare
1237d9f
to
4aadbd2
Compare
401fb64
to
b0bc196
Compare
After spilit out the meta code. the pr is left with only the frontend code which is slightly more than 1k in addition to the tests, the pr can continue to be reviewed |
Left a comment in the previous PR. Might be fixed by the way in this PR. |
fix ddl controller
81672d8
to
6dd8d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for other reviewers' review who are more familiar with optimizer/parser before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please test drop cascade for a table if it is used by a subscription?
create table t (..);
create subscription sub from t;
drop table t cascade;
test it, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I see, no wonder I couldn't find the relevant code in this PR, because it is supported in a previous PR. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this pr,
We added
subscription
to therw_subscriptions
rw_relation
andrw_relation_info
.We support the parse, build_plan and execution of the statements
And in this pr, We have only added tests for SUBSCRIPTION ddl, the specific result tests will be added in the next pr
related #14316
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.