chore(storage): add enable_trivial_move and enable_check_task_overlap
#14801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(storage): commit fix(storage): min overlap picker with config enable_trivial_move chore(storage): add check for skip sub_level Revert "fix(storage): min overlap picker with config enable_trivial_move" This reverts commit 0777d91. fix(storage): fix example config chore(storage): fix opt and add enable_check_skip_level_overlap fix(storage): update check fix(storage): fix task check
Li0k
changed the title
enable_trivial_move and enable_check_task_overlapenable_trivial_move and enable_check_task_overlap
hzxa21
reviewed
Jan 26, 2024
src/meta/src/hummock/compaction/picker/min_overlap_compaction_picker.rs
Outdated
Show resolved
Hide resolved
src/meta/src/hummock/compaction/picker/min_overlap_compaction_picker.rs
Outdated
Show resolved
Hide resolved
|
I simplify the check logic and enrich the check output in 4f4cb61 |
hzxa21
force-pushed
the
li0k/storage_pick_check
branch
from
54f139d to
4f4cb61
Compare
hzxa21
reviewed
Jan 26, 2024
src/meta/src/hummock/compaction/picker/trivial_move_compaction_picker.rs
Outdated
Show resolved
Hide resolved
hzxa21
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.