Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql-udf): introduce udf_binding_flag #14782

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jan 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled, and this PR is a preparation for named sql udf support.

I've tried introducing a runtime binder, but the recursive nature of udf_context makes this approach seemingly impossible.

To KISS, I introduce a simple binding flag to prevent potential naming conflict, since we could ensure there will not be column name inside the body of sql udf. (i.e., every valid identifier in definition should be one of [parameter name / anonymous parameter index / function name])

e.g., the following syntax will be supported in next PR

create function mix_func(INT, a INT, INT) returns int language sql as 'select $1 + a + $3';

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xzhseh xzhseh added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit a4f0ec2 Jan 25, 2024
26 of 27 checks passed
@xzhseh xzhseh deleted the xzhseh/sql-udf-named-parameters branch January 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants