Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avro): fix parsing of avro ref type #14781

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix(avro): fix parsing of avro ref type #14781

merged 2 commits into from
Jan 25, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Jan 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #14702

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jan 24, 2024
@StrikeW StrikeW marked this pull request as ready for review January 24, 2024 12:15
@StrikeW StrikeW requested a review from tabVersion January 24, 2024 12:21
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wondering why we have don this for Schema::Record but missed this in #10368. Any concerns or just forgot? @tabVersion

@StrikeW StrikeW added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit e5c6558 Jan 25, 2024
26 of 27 checks passed
@StrikeW StrikeW deleted the siyuan/fix-avro branch January 25, 2024 13:23
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wondering why we have don this for Schema::Record but missed this in #10368. Any concerns or just forgot? @tabVersion

IIRC, the lib does not support theRef type well. The impl by Siyuan serves as a special case for Decimal in debezium and can not be generalized to other types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RisingWave fails to read Avro schemas that have multiple Debezium VariableScaleDecimals in a single record
3 participants