Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing columns in format_encode_options #14771

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Rossil2012
Copy link
Contributor

@Rossil2012 Rossil2012 commented Jan 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #14755.
The StreamSourceInfo in SourceExecutorBuilder is actually from FragmentManager in Meta, whereas we only do the backward compatibility check in CatalogManager.
A quick fix that copies fields from with_properties to format_encode_options, may move the logic to FragmentManager::init and commit in the meta store in the future.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your effort

@Rossil2012 Rossil2012 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 317b361 Jan 24, 2024
26 of 27 checks passed
@Rossil2012 Rossil2012 deleted the kanzhen/quick-fix-format-encode-options branch January 24, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(source): certain properties/options missing after upgrading from v1.5.0 to v1.6.0
3 participants